Refine CDS how-to guide #41464
Closed
Refine CDS how-to guide #41464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As explained in spring-projectsgh-41348, the BP_SPRING_AOT_ENABLED flag should not be promoted as it can't work by design with our current support when combined with CDS for various use cases and provides little added value as the same behavior can be achieved by adding -Dspring.aot.enabled=true to JAVA_TOOL_OPTIONS and CDS_TRAINING_JAVA_TOOL_OPTIONS.
spring-projects-issues added the status: waiting-for-triage 
wilkinsona added type: documentation wilkinsona pushed a commit that referenced this pull request Jul 12, 2024
As explained in gh-41348, the BP_SPRING_AOT_ENABLED flag should not be promoted as it can't work by design with our current support when combined with CDS for various use cases and provides little added value as the same behavior can be achieved by adding -Dspring.aot.enabled=true to JAVA_TOOL_OPTIONS and CDS_TRAINING_JAVA_TOOL_OPTIONS. See gh-41464
| Thank you, @sdeleuze. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As explained in gh-41348, the
BP_SPRING_AOT_ENABLEDflag should not be promoted as it can't work by design with our current support when combined with CDS for various use cases and provides little added value as the same behavior can be achieved by adding-Dspring.aot.enabled=truetoJAVA_TOOL_OPTIONSandCDS_TRAINING_JAVA_TOOL_OPTIONS.