Change Health.down(Exception) factory method to Health.down(Throwable), aligning with Health.Builder.down(Throwable) #38550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
same as in Builder class
| @anavrotski Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
| @anavrotski Thank you for signing the Contributor License Agreement! |
spring-projects-issues added the status: waiting-for-triage 
| Thanks for the suggestion. I have a feeling this will break binary compatibility so we'll probably have to live with it until 3.3. |
philwebb added for: team-meeting philwebb removed the for: team-meeting | We'll merge this in 3.3. There is a risk that existing libraries might fail in which case they'll need to migrate to |
wilkinsona changed the title wilkinsona pushed a commit that referenced this pull request Jan 5, 2024
| Thanks very much, @anavrotski. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Exception replaced with Throwable (same as in Builder class).