Spring Boot Docker Compose support for Oracle looks for APP_PASSWORD but should look for APP_USER_PASSWORD #37044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…n OracleEnvironment. Created additional integration test to cover non-default container configuration.
| @joesteel2010 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
| @joesteel2010 Thank you for signing the Contributor License Agreement! |
spring-projects-issues added the status: waiting-for-triage 
| Seems to be also handled in #37038, please mention if this provides a better solution, or comment on the other PR. |
scottfrederick removed the status: waiting-for-triage 
snicoll pushed a commit that referenced this pull request Aug 22, 2023
snicoll added a commit that referenced this pull request Aug 22, 2023
| @joesteel2010, thanks very much for making your first contribution to Spring Boot |
snicoll added a commit that referenced this pull request Aug 22, 2023
snicoll added a commit that referenced this pull request Aug 22, 2023
wilkinsona changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit contains a bug fix for #37036
The changes include updates to OracleEnvironment, where APP_PASSWORD has been updated to APP_USER_PASSWORD, OracleEnvironmentTest to cover these changes, and OracleJdbcDockerComposeConnectionDetailsFactoryIntegrationTests includes an additional integration test to cover these changes when using non-defaults for the APP_USER and APP_USER_PASSWORD.
Fixes #37036