Skip to content

Conversation

dangzhicairang
Copy link
Contributor

@dangzhicairang dangzhicairang commented Feb 2, 2023

If there has a more convenient way to configure ConfirmCallback and ReturnsCallback for RabbitTemplate by auto-configure , like declare a bean of ConfirmCallback or ReturnsCallback, so we need not to declare a new bean of RabbitTemplate in extra ConfigClass.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 2, 2023
@dangzhicairang dangzhicairang changed the title Supply more convenient way to configure ConfirmCallback and ReturnsCallback for RabbitTemplate. Supply a way to configure ConfirmCallback and ReturnsCallback for RabbitTemplate. Feb 2, 2023
@dangzhicairang
Copy link
Contributor Author

dangzhicairang commented Feb 2, 2023

I got an error when visiting ci.spring.io/builds/240492.

Error code: 1020 Ray ID: 7931a65cbcdc96a1 Country: CN Data center: sjc06 IP: 171.221.64.103 Timestamp: 2023-02-02 08:45:18 UTC 
@wilkinsona
Copy link
Member

Our CI environment is being upgraded at the moment so it's likely to be unstable for a while.

@philwebb
Copy link
Member

philwebb commented Feb 3, 2023

I wonder if we should instead offer a RabbitTemplateCustomizer callback which could be used to attach a ConfirmCallback, ReturnsCallback or perform any other customization.

@philwebb philwebb added the for: team-attention An issue we'd like other members of the team to review label Feb 3, 2023
@wilkinsona
Copy link
Member

We already have the RabbitTemplateConfigurer that may confuse things a bit. That said, I'm increasingly favour of the …Customizer based approach over defining numerous beans that are only beans so that they can be set on another bean.

@dangzhicairang
Copy link
Contributor Author

We already have the RabbitTemplateConfigurer that may confuse things a bit. That said, I'm increasingly favour of the …Customizer based approach over defining numerous beans that are only beans so that they can be set on another bean.

It's right, i will supply a RabbitTemplateCustomizer like @philwebb said.

@philwebb philwebb added type: enhancement A general enhancement and removed for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged labels Feb 15, 2023
@philwebb philwebb added this to the 3.1.x milestone Feb 15, 2023
# Conflicts: #	spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/amqp/RabbitTemplateCustomizer.java
@mhalbritter mhalbritter self-assigned this Mar 1, 2023
@mhalbritter mhalbritter changed the title Supply a way to configure ConfirmCallback and ReturnsCallback for RabbitTemplate. Add RabbitTemplateCustomizer to allow customization of RabbitTemplates Mar 1, 2023
@mhalbritter
Copy link
Contributor

Thank you!

mhalbritter pushed a commit that referenced this pull request Mar 1, 2023
mhalbritter added a commit that referenced this pull request Mar 1, 2023
@mhalbritter mhalbritter removed this from the 3.1.x milestone Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
6 participants