- Notifications
You must be signed in to change notification settings - Fork 41.6k
Closed
Labels
type: regressionA regression from a previous releaseA regression from a previous release
Milestone
Description
Hello,
I am a Java developer and I have found an issue with the SpringBoot 3.0.4 framework in the org.springframework.boot.logging.logback.LogbackLoggingSystem
class, specifically on line 280.
The current code is as follows:
private void stopAndReset(LoggerContext loggerContext) { loggerContext.stop(); loggerContext.reset(); if (isBridgeHandlerInstalled()) { addLevelChangePropagator(loggerContext); } }
I would like to suggest a modification to this method:
private void stopAndReset(LoggerContext loggerContext) { loggerContext.stop(); loggerContext.reset(); // FIXME: At this point, all initial default states (including appenders and filters) of loggerContext have been cleared. // If other loggers are still printing logs (such as org.springframework.jndi.JndiTemplate which reads environment variable values from <springProperty scope="context" ...>), // a warning noAppenderDefinedWarning will be issued, causing StatusPrinter.printInCaseOfErrorsOrWarnings(loggerContext) to be executed. // This will ultimately result in a large amount of unimportant logs being printed before SpringBoot completes startup. loggerContext.getTurboFilterList().add(FILTER); if (isBridgeHandlerInstalled()) { addLevelChangePropagator(loggerContext); } }
I hope this suggestion is helpful. Thank you for your work on this open source software.
Best regards,
Toby
honza-zidek
Metadata
Metadata
Assignees
Labels
type: regressionA regression from a previous releaseA regression from a previous release