Skip to content

Replace DelegatingAuthenticationConverter with one in Spring Security #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Replace DelegatingAuthenticationConverter with one in Spring Security #1736

wants to merge 1 commit into from

Conversation

franticticktick
Copy link
Contributor

Replacing DelegatingAuthenticationConverter with a similar one from spring security.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 11, 2024
jgrandja
jgrandja requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @CrazyParanoid.

Please address the review comment and then should be ready to merge.
...curity/oauth2/server/authorization/web/authentication/DelegatingAuthenticationConverter.java
* @since 0.0.2
* @see AuthenticationConverter
*/
public final class DelegatingAuthenticationConverter implements AuthenticationConverter {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be removed until 2.0 as it would be a breaking change for a minor.

Instead, please add @Deprecated at the class level and the @deprecated javadoc tag. See applyDefaultSecurity() as an example:

spring-authorization-server/oauth2-authorization-server/src/main/java/org/springframework/security/oauth2/server/authorization/config/annotation/web/configuration/OAuth2AuthorizationServerConfiguration.java

Line 76 in 3b52e15

@Deprecated(since = "1.4", forRemoval = true)

@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 16, 2024
@jgrandja jgrandja self-assigned this Oct 16, 2024
@franticticktick
Copy link
Contributor Author

Hi @jgrandja, thanks for your feedback. All your comments have been resolved.
@jgrandja jgrandja changed the title Replacing DelegatingAuthenticationConverter Replace DelegatingAuthenticationConverter with one in Spring Security Oct 17, 2024
@jgrandja jgrandja added this to the 1.4.0-RC1 milestone Oct 17, 2024
@jgrandja jgrandja closed this in 145599b Oct 17, 2024
@jgrandja
Copy link
Collaborator

Thanks for the update @CrazyParanoid ! This is now merged 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement A general enhancement

3 participants

@franticticktick @jgrandja @spring-projects-issues