Enable base URL to be configurable for OpenAI #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gm2552 reviewed Aug 31, 2023
| @Bean | ||
| public OpenAiService theoOpenAiService(OpenAiProperties openAiProperties) { | ||
| if (!StringUtils.hasText(openAiProperties.getApiKey())) { | ||
| throw new IllegalArgumentException( |
There was a problem hiding this comment.
Would it make sense to only force an API key if the URL was anything other than the default base URL (maybe that's too complex or nondeterministic)?
Member
There was a problem hiding this comment.
I've seen two cases of model hosting projects that expose the OpenAI API locally and do not require a key. I think we can remove the requirement for a key when the base url is not https://api.openai.com and see how it goes.
Member
| I have merged this, just adding a comment that the underlying library will likely add this support as they have an open issue for it. I also enforced the use of the API KEY only if the baseUrl is pointing to api.openai.com commit; 0218069 Thanks for the contribution. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Spring AI currently is fixed on using the official OpenAI URL when working with OpenAI. This makes it impossible to use Spring AI against a locally running OpenAI API such as LocalAI.
This PR exposes a new property (
spring.ai.openai.base-url) that allows for custom configuration of the base URL. It still defaults to the official OpenAI API, though.For example, to use this with a locally running LocalAI listening on port 8080, the following entry can be added to the application.properties file: