fix:Advisor parameters lost when mutate ChatClient #5090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
YunKuiLu commented Dec 13, 2025
YunKuiLu commented - Fixed issue where advisor parameters were lost when advisors were not present during ChatClient mutation.
- Added test case mutateAdvisorParams to ensure correct parameter mutation handling.
- Fixed issue where advisor parameters were lost when advisors were not present during ChatClient mutation. - Added test case mutateAdvisorParams to ensure correct parameter mutation handling. Signed-off-by: YunKui Lu <luyunkui95@gmail.com>
YunKuiLu force-pushed the mutate-advisorParams branch from ec6a20b to e34f837 Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.