Skip to content

Fix missing "thinking" key in Ollama message metadata when streaming. #4951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arlaneenalra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing "thinking" key in Ollama message metadata when streaming. #4951

arlaneenalra wants to merge 1 commit into from

Conversation

@arlaneenalra
Copy link

@arlaneenalra arlaneenalra commented Nov 25, 2025

Fix for #4866

  • Adds "thinking" key to streaming responses.
  • Adds test to prove that the key is present or not present as expected.
@arlaneenalra
Fix missing "thinking" key in Ollama message metadata when streaming.
feedfc6 
Signed-off-by: arlaneenalra <emeraldd.chris@gmail.com>
@arlaneenalra arlaneenalra force-pushed the feat-fix-ollama-thinking-on-streaming branch from d184938 to feedfc6 Compare November 25, 2025 01:19
chriswininger
chriswininger approved these changes Dec 15, 2025
View reviewed changes
Copy link

@chriswininger chriswininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would love to see this fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ollama

3 participants

@arlaneenalra @chriswininger @ilayaperumalg