Skip to content

Conversation

centrumek
Copy link
Contributor

@centrumek centrumek commented Oct 2, 2025

Fix for #4494(raised by @Kehrlann )

This PR refactors the VertexAI auto-configuration modules to align with Spring Boot’s recommended practices and improve test consistency.

Changes

  • Removed unnecessary @ImportAutoConfiguration annotations from VertexAI auto-configuration classes.
  • Updated tests to use private factory vertexAiAutoConfig(...) methods, ensuring that integration test contexts include the same auto-configs that would be present in a real Spring Boot application.
@centrumek centrumek force-pushed the fix/fix-vertex-ai-imports branch 2 times, most recently from f1fb8b8 to b1d7db0 Compare October 2, 2025 16:59
@ilayaperumalg ilayaperumalg added this to the 1.1.0.M3 milestone Oct 3, 2025
@centrumek centrumek force-pushed the fix/fix-vertex-ai-imports branch from b1d7db0 to e7a81ec Compare October 4, 2025 22:27
Signed-off-by: Pawel Potaczala <30981922+centrumek@users.noreply.github.com>
@centrumek centrumek force-pushed the fix/fix-vertex-ai-imports branch from e7a81ec to d1e2363 Compare October 4, 2025 22:28
@ilayaperumalg ilayaperumalg modified the milestones: 1.1.0.M3, 1.1.0.M4 Oct 6, 2025
@ilayaperumalg ilayaperumalg self-assigned this Oct 6, 2025
@ilayaperumalg
Copy link
Member

@centrumek Thanks for the PR!

I see that the other Integration Tests are failing due to missing autoconfigurations. I will fix when merging the PR along with the fixes required for formatting/check-style.

@ilayaperumalg
Copy link
Member

Rebased and merged as d9f5f09 along with the fixes for the failing tests, formatting issues, moved the static methods into an utility class via 9e0e3cd

@centrumek
Copy link
Contributor Author

Thanks @ilayaperumalg, appreciate <3

@centrumek
Copy link
Contributor Author

@ilayaperumalg can you add hacktoberfest-accepted label to this PR, so it can be calculated to my contributions on hacktoberfest page?

Zrzut ekranu 2025-10-6 o 16 38 22

Thanks in advance, if it is possible in spring-ai repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants