Fix intermittent streaming response aggregation test failure #4135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fix OpenAiChatClientIT.beanStreamOutputConverterRecords test that was failing intermittently when run as part of a test suite due to empty streaming chunks causing malformed JSON during aggregation. Changes: - Filter out empty/null text chunks before aggregation to prevent malformed JSON - Replace silent return with explicit test failure when streaming aggregation produces empty results - Add debugging logs to aid troubleshooting of streaming response issues The test now properly detects and reports streaming aggregation problems instead of silently skipping, improving CI reliability and error detection. Auto-cherry-pick to 1.0.x Fixes #4134 Signed-off-by: Mark Pollack <mark.pollack@broadcom.com>
spring-builds pushed a commit that referenced this pull request Aug 13, 2025
Fix OpenAiChatClientIT.beanStreamOutputConverterRecords test that was failing intermittently when run as part of a test suite due to empty streaming chunks causing malformed JSON during aggregation. Changes: - Filter out empty/null text chunks before aggregation to prevent malformed JSON - Replace silent return with explicit test failure when streaming aggregation produces empty results - Add debugging logs to aid troubleshooting of streaming response issues The test now properly detects and reports streaming aggregation problems instead of silently skipping, improving CI reliability and error detection. Fixes #4134 Signed-off-by: Mark Pollack <mark.pollack@broadcom.com> (cherry picked from commit 85c194c)
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…projects#4135) Fix OpenAiChatClientIT.beanStreamOutputConverterRecords test that was failing intermittently when run as part of a test suite due to empty streaming chunks causing malformed JSON during aggregation. Changes: - Filter out empty/null text chunks before aggregation to prevent malformed JSON - Replace silent return with explicit test failure when streaming aggregation produces empty results - Add debugging logs to aid troubleshooting of streaming response issues The test now properly detects and reports streaming aggregation problems instead of silently skipping, improving CI reliability and error detection. Auto-cherry-pick to 1.0.x Fixes spring-projects#4134 Signed-off-by: Mark Pollack <mark.pollack@broadcom.com>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…projects#4135) Fix OpenAiChatClientIT.beanStreamOutputConverterRecords test that was failing intermittently when run as part of a test suite due to empty streaming chunks causing malformed JSON during aggregation. Changes: - Filter out empty/null text chunks before aggregation to prevent malformed JSON - Replace silent return with explicit test failure when streaming aggregation produces empty results - Add debugging logs to aid troubleshooting of streaming response issues The test now properly detects and reports streaming aggregation problems instead of silently skipping, improving CI reliability and error detection. Auto-cherry-pick to 1.0.x Fixes spring-projects#4134 Signed-off-by: Mark Pollack <mark.pollack@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix OpenAiChatClientIT.beanStreamOutputConverterRecords test that was failing intermittently when run as part of a test suite due to empty streaming chunks causing malformed JSON during aggregation.
Changes:
The test now properly detects and reports streaming aggregation problems instead of silently skipping, improving CI reliability and error detection.
Auto-cherry-pick to 1.0.x
Fixes #4134
Signed-off-by: Mark Pollack mark.pollack@broadcom.com