Skip to content

Conversation

@alxkm
Copy link
Contributor

@alxkm alxkm commented Aug 12, 2025

Adds new test cases for ChatClientObservationContext to improve validation and edge case coverage.

Tests Added

  • Null request/prompt validation
  • Advisor list handling (valid, empty, defensive copying)
  • Builder pattern behavior
  • Request reference integrity
  • Default advisor behavior

Impact

  • Improves null safety validation
  • Ensures proper advisor collection handling
  • Validates builder reuse scenarios
Co-authored-by: Oleksandr Klymenko <alexanderklmn@gmail.com> Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com>
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 13, 2025
@sobychacko sobychacko merged commit 9274531 into spring-projects:main Aug 13, 2025
2 checks passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…ects#4124) Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…ects#4124) Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com>
Willam2004 pushed a commit to Willam2004/spring-ai that referenced this pull request Oct 11, 2025
…ects#4124) Signed-off-by: Oleksandr Klymenko <alexanderklmn@gmail.com> Signed-off-by: 家娃 <guanjing.pangj@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants