Skip to content

Conversation

markpollack
Copy link
Member

Summary

This PR adds support for testing GPT-5 models and documents their temperature requirements.

Changes

Test Implementation

  • Added parameterized test chatCompletionEntityWithNewModels in OpenAiApiIT.java
  • Tests both gpt-5 and gpt-5-2025-08-07 models
  • Fixed temperature value to 1.0 for GPT-5 compatibility

Documentation Update

  • Added NOTE section in openai-chat.adoc about GPT-5 temperature requirement
  • Warns users that GPT-5 models only support temperature=1.0

Background

GPT-5 models have a strict temperature requirement and will return an error if any value other than 1.0 is used.

Testing

  • Test passes for both GPT-5 models with temperature=1.0
  • Documentation renders correctly with the new NOTE section

Related Issues

This change addresses model compatibility issues with the new GPT-5 models and improves user documentation to prevent configuration errors.

GPT-5 models (gpt-5, gpt-5-2025-08-07) only support temperature=1.0 and will error with other values. This change adds a parameterized test to validate both models work correctly and updates documentation to warn users about this temperature requirement. - Add chatCompletionEntityWithNewModels test in OpenAiApiIT - Set temperature to 1.0 for GPT-5 compatibility - Add NOTE section in openai-chat.adoc about temperature restriction
- Add GPT_5 and GPT_5_2025_08_07 enum constants to ChatModel in OpenAiApi.java - Update OpenAiApiIT test to use enum constants instead of hardcoded strings - Enhance README.md to highlight support for latest models including GPT-5 - Include JavaDoc documentation with temperature requirement notes (1.0) Fixes GPT-5 model integration with proper type-safe enum constants
@sobychacko
Copy link
Contributor

Merged via 1a3ed95.

@sobychacko sobychacko closed this Aug 7, 2025
@sobychacko sobychacko added this to the 1.1.0.M1 milestone Aug 7, 2025
sobychacko pushed a commit that referenced this pull request Aug 7, 2025
Fixes #4068 - Add GPT_5 and GPT_5_2025_08_07 enum constants to ChatModel in OpenAiApi.java - Update OpenAiApiIT test to use enum constants instead of hardcoded strings - Enhance README.md to highlight support for latest models including GPT-5 - Include JavaDoc documentation with temperature requirement notes (1.0) Add GPT-5 model support and temperature documentation GPT-5 models (gpt-5, gpt-5-2025-08-07) only support temperature=1.0 and will error with other values. This change adds a parameterized test to validate both models work correctly and updates documentation to warn users about this temperature requirement. - Add chatCompletionEntityWithNewModels test in OpenAiApiIT - Set temperature to 1.0 for GPT-5 compatibility - Add NOTE section in openai-chat.adoc about temperature restriction Fixes GPT-5 model integration with proper type-safe enum constants
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment