Keep the same pass check behavior for Evaluator #3975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ancyEvaluator, and avoid NPE. Signed-off-by: Mengqi Xu <2663479778@qq.com>
juntae6942 pushed a commit to juntae6942/spring-ai that referenced this pull request Aug 7, 2025
…ancyEvaluator, and avoid NPE. (spring-projects#3975) Fixes spring-projects#3975 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <2663479778@qq.com>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…ancyEvaluator, and avoid NPE. (spring-projects#3975) Fixes spring-projects#3975 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <2663479778@qq.com>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…ancyEvaluator, and avoid NPE. (spring-projects#3975) Fixes spring-projects#3975 Auto-cherry-pick to 1.0.x Signed-off-by: Mengqi Xu <2663479778@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Keep the same pass check behavior for
FactCheckingEvaluatorandRelevancyEvaluator, and avoid NPE.Some test cases:
evaluationResponseisnull, return false.evaluationResponseisyes, return true.evaluationResponseisYes, return true.evaluationResponseisyES, return true.evaluationResponseisno and yes, return false.evaluationResponseisyes., return false.