Remove hardcoded topK in BedrockConverseProxyChatProperties #3621
+1 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes: spring-projects#3621 Bedrock does not support topK and setting it via BedrockConverseProxyChatProperties does not have any effect. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
sobychacko force-pushed the remove-bedrock-topK-warning branch from efde597 to 6e44f73 Compare 
sunyuhan1998 approved these changes Jun 20, 2025
spring-builds pushed a commit that referenced this pull request Jun 20, 2025
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
…rojects#3621) Fixes: spring-projects#3621 Auto-cherry-pick to 1.0.x Bedrock does not support topK and setting it via BedrockConverseProxyChatProperties does not have any effect. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…rojects#3621) Fixes: spring-projects#3621 Auto-cherry-pick to 1.0.x Bedrock does not support topK and setting it via BedrockConverseProxyChatProperties does not have any effect. Signed-off-by: Soby Chacko <soby.chacko@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Bedrock does not support topK and setting it via BedrockConverseProxyChatProperties does not have any effect.