fix: handle root exceptions in McpToolCallback #3553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Kehrlann force-pushed the dgarnier/fix-tool-call-handling branch from 196e8ac to 86b7c4e Compare 
- Sync and Async McpToolCallback can now handle exceptions where cause == null instead of throwing a NPE. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Kehrlann force-pushed the dgarnier/fix-tool-call-handling branch from 86b7c4e to adae8dc Compare 
tzolov pushed a commit that referenced this pull request Jun 17, 2025
- Sync and Async McpToolCallback can now handle exceptions where cause == null instead of throwing a NPE. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
tzolov pushed a commit that referenced this pull request Jun 17, 2025
- Sync and Async McpToolCallback can now handle exceptions where cause == null instead of throwing a NPE. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
- Sync and Async McpToolCallback can now handle exceptions where cause == null instead of throwing a NPE. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
- Sync and Async McpToolCallback can now handle exceptions where cause == null instead of throwing a NPE. Signed-off-by: Daniel Garnier-Moiroux <git@garnier.wf>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sync and Async McpToolCallback can now handle exceptions where cause == null instead of throwing a NPE.
This is the case when we do OAuth2 flows with Spring Security in MCP tools, because Spring Security relies on exceptions as signals to trigger "fetch an access_token" behavior.