Fixed the issue where tool call information was lost when using DefaultChatOptions. #3417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…DefaultChatOptions. Signed-off-by: Sun Yuhan <1085481446@qq.com>
lambochen reviewed Jun 3, 2025
...-ai-client-chat/src/main/java/org/springframework/ai/chat/client/DefaultChatClientUtils.java Outdated Show resolved Hide resolved
… to `DefaultToolCallingChatOptions` Signed-off-by: Sun Yuhan <sunyuhan1998@users.noreply.github.com>
| Hi @markpollack , I just optimized some of the logic in this PR, and now it looks more concise. Could you please help review it? Thanks! |
| Hi @ilayaperumalg , could you please help review this PR? I noticed @markpollack might be quite busy recently. The changes in this PR are minimal, but they address a frequently occurring issue. |
| LGTM |
| @sunyuhan1998 Thanks for the PR fixing the issue. Rebased and merged as a6dba7d |
| Cherry-picked and pushed into 1.0.x as 29158c82e9e59b59fd77c98e3c8fd34bb43ee07c |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
As #3392 mentioned, when constructing
ChatOptionsusing theChatOptions.builder().build()form, the default instance generated isDefaultChatOptions.When building the
ChatClientRequest, tool call information is lost, causing the tool information to fail to be passed to the LLM, regardless of whether the user uses.defaultToolCallbacks()or directly callstools()on theChatClient.This PR fixes the issue by converting the
ChatOptionstoDefaultToolCallingChatOptionsduring the construction of theChatClientRequest, if theChatOptionsis determined to be aDefaultChatOptionsand tool call information exists in the request.Fixes #3392
Fixes #4169