Skip to content

Conversation

kim-nini
Copy link
Contributor

What

Update .github/PULL_REQUEST_TEMPLATE.md
to replace the obsolete CLA bullet with a DCO bullet.

Why

Spring AI now uses the Developer Certificate of Origin (DCO).
The old CLA link was broken and misleading.

How

  • Replaced the “Sign the CLA” bullet with:
    Add a Signed-off-by line to each commit (\git commit -s`) per the DCO`
  • Kept the remaining bullets (rebase, tests, build) unchanged
  • Added the same DCO link used in the official blog post

No functional code changes, docs only.

Fixes #3094

Copy link
Contributor

@HyunSangHan HyunSangHan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!
I totally agree with you.

Comment on lines +9 to +12
For more details, please check the [contributor guide][1].
Thank you upfront!

[1]: https://github.com/spring-projects/spring-ai/blob/main/CONTRIBUTING.adoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this part is a really detailed contribution that I never thought. 👍

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@kim-nini kim-nini force-pushed the docs/3094-remove-cla-link branch from 77f189b to 2cc297c Compare May 22, 2025 15:10
Signed-off-by: JiyeonNam <duddjektjtro@naver.com>
@dev-jonghoonpark
Copy link
Contributor

Hello, @ilayaperumalg
(Apologies if this mention is not appropriate. I reached out to you because you seem to handle the most merges related to documentation.)

Could you please take a look at this PR when you have some time?
It’s a simple issue, but since it hasn’t been merged yet, duplicate PRs have been created.

Thank you!

@sobychacko sobychacko added this to the 1.1.x milestone Jul 2, 2025
@sobychacko sobychacko added the documentation Improvements or additions to documentation label Jul 2, 2025
@sobychacko sobychacko merged commit ac0c7ee into spring-projects:main Jul 2, 2025
1 check passed
scionaltera pushed a commit to scionaltera/spring-ai that referenced this pull request Sep 3, 2025
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
5 participants