Skip to content

Conversation

@making
Copy link
Member

@making making commented Feb 8, 2024

This pull request updates the API client, which is auto-configured, to utilize a RestClient.Builder that is pre-configured by Spring Boot. This change allows for customization through RestClientCustomizer, enabling the addition of interceptors (such as logging and retry processing) and changing to the underlying request factory.

https://docs.spring.io/spring-boot/docs/current/reference/html/io.html#io.rest-client.restclient.customization

@tzolov
Copy link
Contributor

tzolov commented Feb 8, 2024

Thanks @making , this makes sense.
Will review it soon.

@tzolov
Copy link
Contributor

tzolov commented Feb 9, 2024

@making , Since we introduce an auto-conf dependency on RestClientAutoConfiguration.class in the Ollama, OpenAi, Stability and Vertex AutoConfiguration classes i think we need to add the after e.g.: @AutoConfiguration(after = RestClientAutoConfiguration.class,...) ?

@making
Copy link
Member Author

making commented Feb 9, 2024

@tzolov I missed that point. fixed!

@tzolov
Copy link
Contributor

tzolov commented Feb 9, 2024

Thanks. LGTM. Will merge it shortly.

@tzolov
Copy link
Contributor

tzolov commented Feb 9, 2024

Rebased, squashed and merged at 7b58f42

@making , fyi, I had to add few missing AutoConfigurations.of(RestClientAutoConfiguration.class, before the merge.

@tzolov tzolov closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants