Add Fixes|Closes matching for issue link, too #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The short syntax like `Fixes: #123` is nice, but we lose a link to the target issue when we deal with commit history outside the GitHub. For example, I use commits UI in the IntelliJ IDEA and would like to jump to the issue by clicking link from the commit message. Adding an issue link into a `Fixes|Closes` pattern would let me avoid adding extra link into commit message and this bot would still do its job. Also add a `junit-vintage-engine` dependency to be able to run JUnit 4 test from Gradle
* Fix `or` grouping in the pattern Sometimes I don't have an issue but directly PR. However, I still would like to have back-port issue to be created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The short syntax like
Fixes: #123is nice,but we lose a link to the target issue when we deal with commit history outside the GitHub.
For example, I use commits UI in the IntelliJ IDEA and would like to jump to the issue by clicking link from the commit message. Adding an issue link into a
Fixes|Closespattern would let me avoid adding extra link into commit message and this bot would still do its job.Also add a
junit-vintage-enginedependency to be able to run JUnit 4 test from Gradle