In spin new/add, display only templates compatible with current command #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| I believe the CI failures are spurious. The Go failure has a fix waiting to be merged, and the JS ones seem to have started today. |
tschneidereit approved these changes Jan 21, 2025
Contributor
tschneidereit left a comment
tschneidereit left a comment There was a problem hiding this comment.
Excellent, thank you!
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
itowlson force-pushed the templates-dont-offer-when-doesnt-have-variant branch from f5f501c to d10b10b Compare Collaborator Author
| @fermyon/administrators The CI failures are verified spurious (shenanigans afoot in the JS SDK repo) - can someone force merge this please? Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This addresses an issue noted by @tschneidereit (#2970 (comment)) - if you run
spin addorspin newwithout a template ID, it prompts you for a template, but the prompt lists all templates regardless of if they support the current command variant. For example, if you do aspin add, it listshttp-graineven though that template is currentlynew-only1.This PR filters the selection list based on whether a template supports the current variant.
Footnotes
Because laziness that is why. ↩