Upgrade controller-runtime to v0.16.3 #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MarcosDY commented Oct 20, 2023
| if len(o.Cache.Namespaces) == 0 && configSpec.CacheNamespace != "" { | ||
| o.Cache.Namespaces = []string{configSpec.CacheNamespace} | ||
| if len(o.Cache.DefaultNamespaces) == 0 && configSpec.CacheNamespace != "" { | ||
| o.Cache.DefaultNamespaces[configSpec.CacheNamespace] = cache.Config{} |
Collaborator Author
There was a problem hiding this comment.
controller runtime now supports to have a map of allowed namespaces,
to support that feature we must add new configurations with the more granular configurations,
may we add an issue to address that?
MarcosDY force-pushed the upgrade-controller-runtime branch from fdd3ded to feb9f0f Compare 
added 2 commits December 20, 2023 11:36
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
Signed-off-by: Marcos Yacob <marcos.yacob@hpe.com>
MarcosDY force-pushed the upgrade-controller-runtime branch from feb9f0f to 8213bf9 Compare 
azdagron approved these changes Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.