Skip to content

Conversation

@sixhobbits
Copy link
Collaborator

No description provided.

@sixhobbits sixhobbits requested a review from ndimares January 31, 2024 17:56
openapi.yaml Outdated
- prod
- staging
- dev
# TODO: Wat for OAS3.1 bug fix - Variables in server URLs are not currently supported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be have merged now, would be interested in know what issue you ran into as we use variables successfully in our validator and generator atm

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TristanSpeakEasy - great, should be released soon then I think. Here's what Niel said about it.

I commented out sections that failed strict validation, but will restore this one because the spec will allow for this soon and most libraries should already validate against the future version.

While working on the example schema, I used a strict validator to make sure we don't break things while adding operations etc. The released (JSON/YAML) version of OpenAPI 3.1 still forces valid URLs in Server Objects, but I'm sure they'll release an update soon. Speakeasy's validator correctly interprets the markdown spec here (which is the source of truth, after all), so this was not a Speakeasy problem. We'll uncomment this and update our validator.

@ndimares ndimares changed the base branch from initial-draft to main March 1, 2024 15:02
@ndimares ndimares merged commit 12c2f96 into main Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants