Add $totalResults parameter + update docs #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Could you add test to make sure that this behavior is working correctly? |
| Yes, sure! Is a basic test like the one following in it('can return the specified total') ->expect(fn () => TestModel::jsonPaginate(15, null, 70)) ->toHaveCount(15) // assert that total is 70 // assert that there are 5 pages |
| Thanks! |
| @freekmurze This has introduced a bug for laravel 10.x apps |
| @sebj54 could you take a look at this and PR a fix? |
| @freekmurze Yes, sure. Actually, the reproduction project is not working properly on my side. I can only add a hard check before calling What do you think about it? Also, if you have a recommended way to check Laravel's version, it would help |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi there!
I just a made a small PR to add a new
$totalResultsparameter to thejsonPaginatemethod so it can be passed to theBuilder::paginatemethod.This parameter has been added recently with this PR and its goal is to bypass the counting of total results (for performance mainly, see the PR for more info).
Actually I had to use this because I have a query using the
DISTINCTkeyword and the count I get fromBuilder::paginateis incorrect. There are a ton of issues on this subject and I don't think it will be fixed anytime soon because of the complexity.Feel free to ask if anything should be changed or added :)