Append query parameters to URLs when using cursor pagination #69
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When
use_cursor_pagination
is set totrue
, all the links returned by the paginator do not have query string values appended. This bug was introduced here: d2e38a2For example:
When I make a request to:
GET /cursor?page[size]=5&page[cursor]=eyJpZCI6MTAsIl9wb2ludHNUb05leHRJdGVtcyI6dHJ1ZX0
I expect the
next
andprev
links to look like this in the links data:However, those links lose all query parameters other than the
page[cursor]
and the actual links I'm receiving, look like this:To fix this, I've appended the rest of the query parameters to the cursor paginator.