Remove onboarding avatar tests, they are becoming irrelevant

e2e/playwright/onboarding-tests.spec.ts

@@ -277,141 +277,6 @@ test.describe('Onboarding tests', () => {
  timeout: 10_000,
  })
  })
-
- // (lee) The two avatar tests are weird because even on main, we don't have
- // anything to do with the avatar inside the onboarding test. Due to the
- // low impact of an avatar not showing I'm changing this to fixme.
- test('Avatar text updates depending on image load success', async ({
- context,
- page,
- toolbar,
- homePage,
- tronApp,
- }) => {
- if (!tronApp) {
- fail()
- }
-
- await tronApp.cleanProjectDir({
- app: {
- onboarding_status: '',
- },
- })
-
- // Override beforeEach test setup
- await context.addInitScript(
- async ({ settingsKey, settings }) => {
- localStorage.setItem(settingsKey, settings)
- },
- {
- settingsKey: TEST_SETTINGS_KEY,
- settings: settingsToToml({
- settings: TEST_SETTINGS_ONBOARDING_USER_MENU,
- }),
- }
- )
-
- await page.setBodyDimensions({ width: 1200, height: 500 })
- await homePage.goToModelingScene()
-
- // Test that the text in this step is correct
- const avatarLocator = toolbar.userSidebarButton.locator('img')
- const onboardingOverlayLocator = page
- .getByTestId('onboarding-content')
- .locator('div')
- .nth(1)
-
- // Expect the avatar to be visible and for the text to reference it
- await expect(avatarLocator).toBeVisible()
- await expect(onboardingOverlayLocator).toBeVisible()
- await expect(onboardingOverlayLocator).toContainText('your avatar')
-
- // This is to force the avatar to 404.
- // For our test image (only triggers locally. on CI, it's Kurt's /
- // gravatar image )
- await page.route('/cat.jpg', async (route) => {
- await route.fulfill({
- status: 404,
- contentType: 'text/plain',
- body: 'Not Found!',
- })
- })
-
- // 404 the CI avatar image
- await page.route('https://lh3.googleusercontent.com/**', async (route) => {
- await route.fulfill({
- status: 404,
- contentType: 'text/plain',
- body: 'Not Found!',
- })
- })
-
- await page.reload({ waitUntil: 'domcontentloaded' })
-
- // Now expect the text to be different
- await expect(avatarLocator).not.toBeVisible()
- await expect(onboardingOverlayLocator).toBeVisible()
- await expect(onboardingOverlayLocator).toContainText('the menu button')
- })
-
- test("Avatar text doesn't mention avatar when no avatar", async ({
- context,
- page,
- toolbar,
- homePage,
- tronApp,
- }) => {
- if (!tronApp) {
- fail()
- }
-
- await tronApp.cleanProjectDir({
- app: {
- onboarding_status: '',
- },
- })
- // Override beforeEach test setup
- await context.addInitScript(
- async ({ settingsKey, settings }) => {
- localStorage.setItem(settingsKey, settings)
- localStorage.setItem('FORCE_NO_IMAGE', 'FORCE_NO_IMAGE')
- },
- {
- settingsKey: TEST_SETTINGS_KEY,
- settings: settingsToToml({
- settings: TEST_SETTINGS_ONBOARDING_USER_MENU,
- }),
- }
- )
-
- await page.setBodyDimensions({ width: 1200, height: 500 })
- await homePage.goToModelingScene()
-
- // Test that the text in this step is correct
- const sidebar = toolbar.userSidebarButton
- const avatar = sidebar.locator('img')
- const onboardingOverlayLocator = page
- .getByTestId('onboarding-content')
- .locator('div')
- .nth(1)
-
- // Expect the avatar to be visible and for the text to reference it
- await expect(avatar).not.toBeVisible()
- await expect(onboardingOverlayLocator).toBeVisible()
- await expect(onboardingOverlayLocator).toContainText('the menu button')
-
- // Test we mention what else is in this menu for https://github.com/KittyCAD/modeling-app/issues/2939
- // which doesn't deserver its own full test spun up
- const userMenuFeatures = [
- 'manage your account',
- 'report a bug',
- 'request a feature',
- 'sign out',
- ]
- for (const feature of userMenuFeatures) {
- await expect(onboardingOverlayLocator).toContainText(feature)
- }
- })
 })
 
 test('Restarting onboarding on desktop takes one attempt', async ({