Skip to content

Fix #12, #16, #18: Add GitHub OAuth, error handling, and navigation with Jetpack Compose #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: base-sha/c5294370e3aeff90077e8c2c1b8c595cf0316833
Choose a base branch
from
Open

Fix #12, #16, #18: Add GitHub OAuth, error handling, and navigation with Jetpack Compose #2

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
463e490
Add LoginButton composable and integrate it into MainActivity
theMr17 Apr 27, 2025
d084a29
Add CLIENT_ID and CLIENT_SECRET to buildConfig in debug and release b…
theMr17 Apr 27, 2025
ed82b5a
Add GitHub OAuth integration with LoginButton and createGitHubAuthIntent
theMr17 Apr 27, 2025
7058ed3
Add LoginScreen composable and update MainActivity to use it
theMr17 Apr 27, 2025
bbedd44
Add authentication feature with ViewModel, data sources, and error ha…
theMr17 Apr 28, 2025
1b7b3b5
Add ConnectingToGitHubScreen and navigation setup in MainActivity
theMr17 Apr 28, 2025
9c6c7ac
Update build.gradle.kts to handle missing local.properties gracefully…
theMr17 Apr 28, 2025
2cda0cc
Add GitHub connection handling with state management and navigation s…
theMr17 Apr 29, 2025
2bb8b02
Rename authentication-related classes and update references to improv…
theMr17 Apr 29, 2025
b710a5e
Update SetupStep enum documentation to clarify token retrieval proces…
theMr17 Apr 29, 2025
99577cd
Merge branch 'main' into feat/setup-authentication-flow
theMr17 May 1, 2025
6e396b2
Fix daggerHilt variable name
theMr17 May 1, 2025
bbb0150
Refactor error handling in DataStore operations and update related cl…
theMr17 May 1, 2025
0d604e8
Update test script to include verbose output for connectedAndroidTest
theMr17 May 1, 2025
de4f862
Enhance test script to handle emulator termination on test failure
theMr17 May 1, 2025
a34fa01
Revert changes to test.yml
theMr17 May 1, 2025
fb5a0cd
Refactor DataStoreManager tests to assert Result type and improve cla…
theMr17 May 1, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add CLIENT_ID and CLIENT_SECRET to buildConfig in debug and release b… 
…uilds
  • Loading branch information
@theMr17
theMr17 committed Apr 27, 2025
commit d084a29f37e4bc2dbb8cd03e31d41424c73b0a64
10 changes: 10 additions & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import java.util.Properties

plugins {
alias(libs.plugins.android.application)
alias(libs.plugins.kotlin.android)
Expand All @@ -22,12 +24,20 @@ android {
}

buildTypes {
val properties = Properties().apply {
load(project.rootProject.file("local.properties").inputStream())
}

debug {
buildConfigField("String", "BASE_URL", "\"https://api.github.com/\"")
buildConfigField("String", "CLIENT_ID", "\"${properties.getProperty("CLIENT_ID")}\"")
buildConfigField("String", "CLIENT_SECRET", "\"${properties.getProperty("CLIENT_SECRET")}\"")
}
release {
isMinifyEnabled = false
buildConfigField("String", "BASE_URL", "\"https://api.github.com/\"")
buildConfigField("String", "CLIENT_ID", "\"${properties.getProperty("CLIENT_ID")}\"")
buildConfigField("String", "CLIENT_SECRET", "\"${properties.getProperty("CLIENT_SECRET")}\"")
proguardFiles(
getDefaultProguardFile("proguard-android-optimize.txt"),
"proguard-rules.pro"
Expand Down