This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.5.x] Context: return lines around symbol match #63788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This PR fixes an important bug in #62976, where we didn't properly map the symbol line match to the return type. Instead, we accidentally treated symbol matches like file matches and returned the start of the file. ## Test plan Add new unit test for symbol match conversion. Extensive manual testing. (cherry picked from commit 004eb0f)
jtibshirani approved these changes Jul 11, 2024
jtibshirani requested review from a team, Chickensoupwithrice and jdpleiness and removed request for a team and jdpleiness 
Contributor
| I'd like to get this in for the release next week! I wasn't sure if I needed to backport to do so. I will close this out if it's not necessary. |
mmanela approved these changes Jul 11, 2024
jdpleiness approved these changes Jul 11, 2024
Chickensoupwithrice approved these changes Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR fixes an important bug in #62976, where we didn't properly map the
symbol line match to the return type. Instead, we accidentally treated symbol
matches like file matches and returned the start of the file.
Test plan
Add new unit test for symbol match conversion. Extensive manual testing.
Backport 004eb0f from #63773