This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Bug fix: add label to OpenCodeGraph icon #60380
Open
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Before, the OpenCodeGraph icon was the only action without a label:

Now, the icon has a label, along with a more descriptive tooltip.

This PR also contains a small refactor that deduplicates some code.
A few questions for the team:
OpenCodeGraphandCodeGraphand felt like they both looked a little clunky next to the rest of the labels. Open to suggestions here.client/web/src/repo. Whereas, the OpenCodeGraph toggle lives inclient/web/src/opencodegraph/global. It wasn't a big deal to find it, but it did take a bit more digging than expected. Seems a bit out of place to me.Test plan
Manual/visual testing. CI/CD passing.