This repository was archived by the owner on Sep 30, 2024. It is now read-only.
conf: add docs and default value for email.senderName #55139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fixes #54984 by setting a default value for `email.senderName` and documenting the setting. I also changed the docs to have valid syntax and changed from `domain.com` to `example.com`, which is the preferred way to refer to example emails.
Contributor
| Codenotify: Notifying subscribers in CODENOTIFY files for diff 0633c1d...166a896.
|
sashaostrikov approved these changes Jul 20, 2023
Contributor
sashaostrikov left a comment
sashaostrikov left a comment There was a problem hiding this comment.
LGTM! Added a question about lulz
eseliger reviewed Jul 20, 2023
| | ||
| // EmailSenderName returns `email.senderName`. If that's not set, it returns | ||
| // the default value "Sourcegraph". | ||
| func EmailSenderName() string { |
Member
There was a problem hiding this comment.
What am I missing 🤔 where is this function called?
Contributor Author
There was a problem hiding this comment.
omg, you're right.
mrnugget added a commit that referenced this pull request Jul 21, 2023
This is a follow-up to #55139 and _actually_ uses the new value I added.
mrnugget added a commit that referenced this pull request Jul 21, 2023
This is a follow-up to #55139 and _actually_ uses the new value I added. ## Test plan - N/A
MaedahBatool pushed a commit that referenced this pull request Jul 28, 2023
This is a follow-up to #55139 and _actually_ uses the new value I added. ## Test plan - N/A
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fixes #54984 by setting a default value for
email.senderNameand documenting the setting.I also changed the docs to have valid syntax and changed from
domain.comtoexample.com, which is the preferred way to refer to example emails.Test plan