change CACHE_DIR env var to SYMBOLS_CACHE_DIR in symbols template #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
michaellzc approved these changes Mar 3, 2023
| patch release process: https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/RELEASE.md |
DaedalusG added a commit to sourcegraph/sourcegraph-public-snapshot that referenced this pull request Mar 3, 2023
Depends on sourcegraph/deploy-sourcegraph-helm#258 _^^ Don't merge till this is validated!_ ## Test plan `sg run docsite` <!-- All pull requests REQUIRE a test plan: https://docs.sourcegraph.com/dev/background-information/testing_principles -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug introduced into the helm charts as a result of changes in
sourcegraph/sourcegraph, TL;DRCACHE_DIRwas renamed toSYMBOLS_CACHE_DIR. This causes some symbols searches to fail to resolve --Temporary Fix till this is merged
You can add the following to your
override.yaml:and apply the changes to your cluster with --
Checklist
Test plan