code_style: use switch expressions for simple value mapping #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
love-linger force-pushed the develop branch 6 times, most recently from 05dba32 to 6822ae3 Compare love-linger force-pushed the develop branch 3 times, most recently from 072502a to 5ce919a Compare love-linger force-pushed the develop branch 5 times, most recently from f325aaf to 6511d15 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Switch expressions provide a nice compact way to convert values, especially to/from enums.
This PR introduces switch expressions where they make sense, in particular a new
Models.Change.ChangeStateFromCodefunction (feel free to rename) that dramatically simplifies theQueryLocalChangescommand.