[UI] Unify looks between file viewer and history file content #1398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I've pushed my implement of this PR |
For reference, this was done in commit ac55bed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently there is a ui discrepancy in the files content viewer, compared to the changes and file history content viewers, in that it is missing a header bar with it's filename. I've tried to unify the looks of them by moving the header from the FileHistories content viewer to a new intermediate FileContentViewer.
One of the reasons I think it is nice to unify is that it enables the option of adding toggle buttons such as the ones in the changes view when viewing content in the different places. As an example, I'm looking into creating a PR with the option to turn of bitmap interpolation, which currently makes small images very blurry and it would be nice to have a toggle mode in each of the image viewers.
Here is some images of the current ui:
Files browser without the header
Files browser with my proposed changes:
Changes tab and file history content with the header for reference:
My change does however introduce an empty field when no file is selected, which might be a personal preference if it's a bother or not.
