Addresses the cosmetic bug on p 371 (now 369) #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This branch adds an edge case to snippet processing that uses a normal hard line break (
\\) instead of our built-in spacing command (\PromptInputSpace) when it compiles a<JAVASCRIPT_PROMPT>if the snippet occurs inside a list (OL) environment.There is only one such case in the entire book on p 369 (p 371 in the initial submit).
You can uncomment line 165 instead of 166 in
processSnippetPDF.jsto have the command also output****into the PDF right before the hard line break. You can then seach for****to verify that there is indeed only a single case of this in the book.Here is what the case on p. 369 looks like with that debug code turned on. Observe that the spacing is good, which is the bug we are trying to fix.
Obviously, this code incurs some technical debt that we don't want but I consider this the right fix for now.