Addition to snippet macros #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This is a prerequisite to pagination PRs so I'd appreciate a speedy merge of this -- so I can rebase those PR's on master and have these commands defined. |
martin-henz approved these changes Nov 4, 2021
| const jsLonelySnippet = node.getElementsByTagName("JAVASCRIPT_LONELY")[0]; | ||
| const jsSnippet = node.getElementsByTagName("JAVASCRIPT")[0]; | ||
| const jsOutputSnippet = node.getElementsByTagName("JAVASCRIPT_OUTPUT")[0]; | ||
| const allowBreakAfter = |
There was a problem hiding this comment.
name of the constant "allowBreakAfter" is confusing. This should be "forceBreakAfter" isn't it?
| Merged. I don't know your plans about page breaks. Before you get serious about pagination, you may consider choosing the right names. A command that forces page breaks should not be called ALLOW_BREAK. But maybe you want it to just "allow a break"? Should we identify the MIT-Press-specific commands as such so that we can easily turn them off if we want to change the formatting? How about MIT_PAGE_BREAK? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR adds a new command
ALLOW_BREAKwhich is a placeholder for now -- it is simply an alias ofSHORT_SPACE_AND_ALLOW_BREAK.This command is used in a few places in the pagination.
Further, we add the attribute
BREAK_AFTERtoJAVASCRIPTtags inside a snippet, that should work thus:In this case, the snippet is just a single snippet so this should be ignored.
In this case, the first snippet should be compiled to LaTeX such that a \pagebreak is inserted between it and the output snippet.