Skip to content

Conversation

@martin-henz
Copy link
Member

No description provided.

@martin-henz
Copy link
Member Author

martin-henz commented May 19, 2021

First PDF in this branch:
sicpjs.pdf

@martin-henz
Copy link
Member Author

fixes #470

@martin-henz
Copy link
Member Author

martin-henz commented May 21, 2021

Julie requested some space between ) and x. There were five occurrences of this in 2.5.3. I have added a "think space" using , between ) and x:

henz@workshops-MBP sicp % grep -r ")\\\\,x" xml xml/chapter2/section5/subsection3.xml: \[ (y^2 +1)\,x^3 +(2y)\,x+1 \] xml/chapter2/section5/subsection3.xml: {\left[3x^2 +(2+3i)\,x+7\right] \cdot \left[x^4 +\frac{2}{3}x^2 xml/chapter2/section5/subsection3.xml: {\left[ (y+1)\,x^2 +(y^2 +1)\,x+(y-1)\right]\cdot \left[(y-2)\,x+(y^3 +7)\right]} xml/chapter2/section5/subsection3.xml: {\left[ x^2 +(y+1)\,x+5\right]+ \left[ x^2 +2x+1\right]} henz@workshops-MBP sicp % 

Not sure if this is a good move. Here is the result. See pages 180 and 184 (including footnote 55).

Here is the resulting sicpjs.pdf of this branch:
sicpjs.pdf

@martin-henz
Copy link
Member Author

@TobiasWrigstad can you review this PR?

@TobiasWrigstad
Copy link
Collaborator

@martin-henz I liked the thin spaces but it seems they were removed almost immediately? How come?

Copy link
Collaborator

@TobiasWrigstad TobiasWrigstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everything looks good. I liked the thin spaces, but I suspect there is a good reason to remove them. And it is certainly readable both with and without.

\[k_1f(n) \leq R(n) \leq k_2f(n)\]
\[
\begin{array}{lll}
k_1f(n) & \leq & R(n) \quad \leq \quad k_2f(n)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment: the subscripts of k overlap with the serif of the f. Moving from k_1 and k_2 to e.g. k and k' would solve this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not proposing that we make that change. Just pointing it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added thin spaces , after k_1 and k_2 to avoid the overlap. This now looks the same as in SICP.

{\left[ (y+1)x^2 +(y^2 +1)x+(y-1)\right]\cdot \left[(y-2)
x+(y^3 +7)\right]}
\begin{array}{l}
{\left[ (y+1)x^2 +(y^2 +1)x+(y-1)\right]\cdot \left[(y-2)x+(y^3 +7)\right]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the thin space looked good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the explanation is in the email. Let's LaTeX do this and not micro-manage, unless we have to, as in the case of k_1 f(...) and k_2 f(...)

propagates its value through the network as described above. This
sets <SCHEMEINLINE>F</SCHEMEINLINE> to 77, which is reported by the probe
on <SCHEMEINLINE>F</SCHEMEINLINE>.
on<SPACE/><SCHEMEINLINE>F</SCHEMEINLINE>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition with the hard space.

Then the required stream may be constructed with
<SCHEMEINLINE>merge</SCHEMEINLINE>, as follows:
<SNIPPET EVAL="no" LATEX="yes" POSTPADDING="no">
<SNIPPET EVAL="no" LATEX="yes">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this one!

@TobiasWrigstad
Copy link
Collaborator

Sorry about the delay.

@martin-henz
Copy link
Member Author

I think everything looks good. I liked the thin spaces, but I suspect there is a good reason to remove them. And it is certainly readable both with and without.

Not sure how "thin spaces" disappeared. Is it because we moved to "array" instead of just [ ]?

@martin-henz
Copy link
Member Author

@martin-henz I liked the thin spaces but it seems they were removed almost immediately? How come?

Ah, yes. The reason is in the emails. I want to let LaTeX take care of the spacing. Manually inserting them seems like an overkill to me. We would have to go through the whole book to get a uniform manual spacing. That would be a waste of time, I think.

An exception: When LaTeX does an obviously poor job, as in the case of k_1 f(...) and k_2 f(...).

@martin-henz martin-henz merged commit 6b165a6 into master May 30, 2021
@RichDom2185 RichDom2185 deleted the equations branch July 7, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants