Environment model with constants #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| Accidentally managed to add dd35bdb to PR as well. |
martin-henz requested changes Jun 26, 2020
Member
martin-henz left a comment
martin-henz left a comment There was a problem hiding this comment.
This should say "other names" instead of "other variables", to be consistent with the text and with Figure 3.2.
This should say "make_withdraw" instead of "make_withdraw_with_balance". (The longer name was consistent with an earlier version of the JS adaptation; in the meantime I reverted to a version that is closer to the original Scheme version.)
Same here: make_withdraw_with_balance -> make_withdraw
...and here.
...and finally here.
…sing to edit svg)
Collaborator Author
| Updated with bug fixes and fixes to the above. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #252
I may be mistaken, but I think all constants in the environment model pictures are names of functions, not
constconstants. Needs reviewing.