Adds a permalink capability following #120 #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Clicking a <p>..</p> tag copies the permalink - Visual queues using Jquery-ui (new dependency), highlight + message box - Format of permalink is http://localhost:3000/chapters/6#p5 to get to 5th paragraph of Chapter 6
Closed
| Update to this PR will come in 10 minutes -- I spotted a violation of HTML nesting rules |
| I love this feature! I think it will improve the utilization of the textbook a lot because we can link directly into the specific paragraphs. Played with Chapter 2. The copying of permalinks works for the intro of Chapter 2, but does not work for Section 2.1. |
| Thanks! I missed adding a hook to the function that dynamically loads content. Will fix after lunch. |
| We might also consider adding the same for headings |
- Updates to newer bootstrap (fixes one bug with current system unrelated to this PR) - Exercises and headings are now permalinked - Handles dynamically loaded content
| Please squash on merge! |
| This is amazing! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
<p>..</p>tag copies the permalinkAddresses #120 although it does not use right-click (which can be fixed, but then people will not see it).