Support clicks on child elements in button click tracking (close #1280) #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
BundleMonFiles added (6)
Total files change +97.32KB 0% Final result: ✅ View report in BundleMon website ➡️ |
jethron approved these changes Jan 10, 2024
Contributor
jethron left a comment
jethron left a comment There was a problem hiding this comment.
LGTM, thanks @matus-tomlein!
One day I'll take the time to get node@16 working so the tests work locally. :P
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue #1280
This reopens the PR #1279 from @jethron that fixes the issue where clicks on buttons with child elements are not recognized.