Added feature to allow test file as spec.js & Extended it to create t… #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…he storybook component
Owner
| @chandanrjit Great addition! I will have a look at it soon |
snaerth reviewed Nov 12, 2018
lib/index.js Outdated
| | ||
| if (!notest && !(config && config.includes('notest'))) { | ||
| files.push(`${name}.test.${ext}`); | ||
| if((config && config.includes('spec'))) |
Owner
There was a problem hiding this comment.
I use curly braces in my projects :)
snaerth reviewed Nov 12, 2018
lib/utils/stringHelper.js Outdated
| * @param {*} string | ||
| * @returns | ||
| */ | ||
| function componentNameWithoutSpecialCharacter(string){ |
Owner
There was a problem hiding this comment.
This function can be much shorter and you should remove lodash. Please write it like this
/** * Removes special characters from string makes every camel case character uppercase * * @param {String} str - String to transform * @returns {String} */ function componentNameWithoutSpecialCharacter(str){ return str.split('-').map(capitalizeFirstLetter).join('') } snaerth reviewed Nov 12, 2018
Owner
There was a problem hiding this comment.
@chandanrjit Great addition. Please fix some of the comments I made and then I will test the PR. And thank you for this :)
Owner
Contributor Author
| updated PR with recommedations |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi , it is wonderful module and i have add few changes which may required by others