Improving debugger.py #41
Open
+42 −35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use typing to make the function signatures clearer. Use constants for hard-coded values. Create a helper function for checking file extensions. Improve the error handling in the walk_directory function. Use f-strings for better readability and performance. Add function and module-level docstrings for better understanding of the code.
Contributor
| thats great, thanks so much! the biggest issue with debugger is that context length becomes a problem much sooner than most. would like to fix that next, but happy to discuss what the right approach is in issues (i may move faster than issues here) |
swyxio reviewed May 29, 2023
Contributor
| i have not merged yet because i'm not sure that this is how i want the code style to be, but also have not closed because i might come around to it |
Author
| Ok sounds good. Let me know if there's anything else I can do. |
Contributor
| you've done great. just share usecases/examples/pain points! i'll be refactoring quite a bit this week to accommodate the enlarged planning. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Sorry for the size of this PR. Issues to fix kept growing. See below:
Use typing to make the function signatures clearer.
Use constants for hard-coded values.
Create a helper function for checking file extensions.
Improve the error handling in the walk_directory function.
Use f-strings for better readability and performance.
Add function and module-level docstrings for better understanding of the code.