Add getter for GlobalLoggerGuard #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Set the property public so that those who set Logger global can figure out whether the logger is set already
Contributor
| Please make it a getter instead, in case we need to stuff more fields in that struct at some point. |
dpc approved these changes Oct 24, 2019
Contributor
| Please keep asking me to release it until I do. Me busy, but trying to help. |
Contributor Author
| Ok then I will ask everyday 🙃 |
hskang9 changed the title Contributor Author
| hey have you released it yet? |
Contributor Author
| Hello @dpc , have you released the change? |
Contributor
| Done. |
Contributor Author
| Thank you for your time. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Set the property public so that those who set Logger global can figure out whether the logger is set already with accessing its GlobalLoggerGuard's property after return from
set_global_logger.