Upgrade to slog v2.8, Improve CI, and bump version to v2.7.0 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has been deprecated in favor of cfg(clippy) and namespaced lints.
Always supported on modern rust & avoids a deprecation warning in slog v2.8. See slog-rs/slog@48e4651 for details. This change has no affect on behavior and does not fix a bug, so does not need to be noted in the changelog.
This comment was marked as resolved.
This comment was marked as resolved.
Copied from slog-rs/slog
Based off ones in the slog-rs/slog main repo.
Techcable force-pushed the upgrade/slog-v2.8.0 branch from 6665d51 to f21d886 Compare Techcable force-pushed the upgrade/slog-v2.8.0 branch from 1043e88 to 781a5b1 Compare Techcable changed the title Techcable force-pushed the upgrade/slog-v2.8.0 branch 2 times, most recently from b4f37d0 to e5bd024 Compare Helpful for old rust versions circa 1.61, which use the legacy index.
Techcable force-pushed the upgrade/slog-v2.8.0 branch 3 times, most recently from e732f79 to dfdef8f Compare Implement Drain::flush and enable the `nested-values` feature by default.
Similar to something we do in slog-term, but with way more pinned dependencies. It would be nice to do this automatically.
Use cargo package renaming to avoid changing any code.
Date in changelog will likely be incorrect due to merge delay (I cannot commit to master).
Techcable force-pushed the upgrade/slog-v2.8.0 branch from dfdef8f to 22560c3 Compare 
| Please do not merge this until slog v2.8.1 is released and I update this appropriately. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Improves the CI, implement
Drain::flush, and enables thenested-valuesfeature by default.This also bumps the minor version from 2.6 to 2.7. I would normally do this in a separate PR/commit to master, but I don't have admin permissions on this repo.