Fix potential vulnerable clone function #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… vulnerability in unescape()
Contributor Author
| Hi @slajerek, Just want to let you know that we plan to submit a CVE for this issue. Please let us know if you have any concerns. Many thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Our tool detected a potential out-of-bound read vulnerability in
unescape()insrc/Emulators/vice/monitor/mon_lex.cwhich was cloned from GNUAspell/aspell@80fa26c but did not receive the security patch. The original issue was reported and fixed under CVE-2019-17544.Proposed Fix
Apply the same patch to eliminate the vulnerability.
Reference
https://nvd.nist.gov/vuln/detail/CVE-2019-17544
GNUAspell/aspell@80fa26c