Skip to content

Conversation

@AnujRNair
Copy link
Contributor

Summary

This will allow the enabled property to accept a function - this will allow conditionally turning on and off the CSP plugin for different HTMLWebpackPlugin compilations in the same webpack config file.

Requirements (place an x in each [ ])

@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #8 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #8 +/- ## ===================================== Coverage 100% 100% ===================================== Files 2 2 Lines 98 110 +12 Branches 4 5 +1 ===================================== + Hits 98 110 +12
Impacted Files Coverage Δ
spec/plugin.spec.js 100% <100%> (ø) ⬆️
plugin.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ea980a...c2af278. Read the comment docs.

@rowanoulton rowanoulton self-assigned this Feb 21, 2018
Copy link

@rowanoulton rowanoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AnujRNair AnujRNair merged commit 098ec0c into master Feb 21, 2018
@AnujRNair AnujRNair deleted the an-enabled-as-function branch February 21, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants