Skip to content

Conversation

@AnujRNair
Copy link
Contributor

Summary

Cleaning up the plugin instance by referencing the instance variables for the policy, and the user defined policy, and adding more comments so it's easier to follow along with what the code is doing

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #25 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #25 +/- ## ========================================= - Coverage 93.75% 93.5% -0.25%  ========================================= Files 2 2 Lines 80 77 -3 Branches 11 11 ========================================= - Hits 75 72 -3  Misses 4 4 Partials 1 1
Impacted Files Coverage Δ
plugin.js 91.07% <100%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bc24c...90c74fd. Read the comment docs.

@AnujRNair AnujRNair merged commit 6da3843 into master Dec 20, 2018
@AnujRNair AnujRNair deleted the an-cleanup-for-refactor branch December 20, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants