An option for disabling unsafe inline #22
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Previously, we added functionality to not generate hashes if
unsafe-inlinewas specifically added to a policy by a developer, however, this breaks csp backwards compatibility with older browsers.According to MDN:
The same applies to hashes
This PR has added in a new config option (
devAllowUnsafe) to allow the developer to stop inline hash processing if set. Otherwise, a policy will be created with bothunsafe-inlineand inline script hashesRequirements (place an
xin each[ ])