Skip to content

Conversation

@sibiraj-s
Copy link
Contributor

Summary

Hi,

This should disable the plugin from htmlwebpackplugin. this comes handy in a very large applications where CSP plugin is not expected to add meta tags for particular/few html files

Requirements

@codecov
Copy link

codecov bot commented Nov 29, 2018

Codecov Report

Merging #21 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #21 +/- ## ========================================== + Coverage 98.71% 98.79% +0.07%  ========================================== Files 2 2 Lines 156 166 +10 Branches 8 9 +1 ========================================== + Hits 154 164 +10  Misses 2 2
Impacted Files Coverage Δ
spec/plugin.spec.js 100% <100%> (ø) ⬆️
plugin.js 96.77% <100%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d642ce...2749b88. Read the comment docs.

Copy link
Contributor

@AnujRNair AnujRNair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition! This is a nice feature addition for those who use multiple instances of HTMLWebpackPlugin in a single webpack compilation

@AnujRNair AnujRNair merged commit b0adaea into slackhq:master Nov 29, 2018
@sibiraj-s sibiraj-s deleted the disable-csp-from-htmlplugin branch November 30, 2018 03:37
@sibiraj-s
Copy link
Contributor Author

hi @AnujRNair thanks for the swift response. Can you make a feature release. this #15 is a little important and we do need it now. rite now we are directly including this plugin from Github for the fix.

@AnujRNair
Copy link
Contributor

Done!

@sibiraj-s
Copy link
Contributor Author

Thanks 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants