Add meta tag if it doesn't exist #13
Conversation
AnujRNair left a comment
AnujRNair left a comment There was a problem hiding this comment.
Thanks for your contribution! 2 small changes requested :)
spec/plugin.spec.js Outdated
| ); | ||
| }); | ||
| | ||
| it('adds meta tag when no template is specified', done => { |
There was a problem hiding this comment.
Maybe adds meta tag with completed policy when the entire meta tag is missing?
| plugins: [ | ||
| new HtmlWebpackPlugin({ | ||
| filename: path.join(OUTPUT_DIR, 'index.html'), | ||
| inject: 'body' |
There was a problem hiding this comment.
Would you be able to create a new template with-no-meta-tag.html and explicitly set it here, using the template param? Example above :)
That way, if other examples change, this one won't start failing
There was a problem hiding this comment.
Okay I'll add a with-no-meta-tag.html test case.
Wouldn't you still want this original test case in addition to what you requested? This test case specifies no template at all, using the automatically generated template from HtmlWebpackPlugin. How would it start failing if other examples changed?
There was a problem hiding this comment.
No template defaults to an index.html file, so if your changes are able to add the missing meta tag to the specified template here, it should add it to the one with no template too!
I was initially thinking that if HTML Webpack Plugin changed something (like started requiring a template), then this example may start failing
AnujRNair left a comment
AnujRNair left a comment There was a problem hiding this comment.
This looks great, thanks for the addition!
2 participants
Summary
Add tag if it doesn't exist. Feature request in #12
Requirements