Webpack 4 refactor #11
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #11 +/- ## ========================================== - Coverage 100% 98.34% -1.66% ========================================== Files 2 2 Lines 117 121 +4 Branches 5 6 +1 ========================================== + Hits 117 119 +2 - Misses 0 2 +2
Continue to review full report at Codecov.
|
AnujRNair left a comment
AnujRNair left a comment There was a problem hiding this comment.
Hi @ScottRocha!
Thanks for contributing to this project!
I've added a few comments for your consideration
| ); | ||
| }); | ||
| } else { | ||
| compiler.plugin('compilation', compilation => { |
There was a problem hiding this comment.
Would you be able to reduce the code duplication here? Abstracting the main body of the compilation step out would help keep test coverage of the entire project high, and would be better for maintainability
There was a problem hiding this comment.
Can do. Give me a few.
plugin.js Outdated
| if (!this.isEnabled(htmlPluginData)) { | ||
| $('meta[http-equiv="Content-Security-Policy"]').remove(); | ||
| if (compiler.hooks) { | ||
| compiler.hooks.compilation.tap('HtmlWebpackHarddisk', compilation => { |
There was a problem hiding this comment.
HtmlWebpackHarddisk should be updated to CspHtmlWebpackPlugin
There was a problem hiding this comment.
This has been updated in the latest commit.
plugin.js Outdated
| if (compiler.hooks) { | ||
| compiler.hooks.compilation.tap('HtmlWebpackHarddisk', compilation => { | ||
| compilation.hooks.htmlWebpackPluginAfterHtmlProcessing.tapAsync( | ||
| 'HtmlWebpackHarddisk', |
There was a problem hiding this comment.
This should also be updated to match the plugin name
There was a problem hiding this comment.
This has also been updated in the latest commit.
There was a problem hiding this comment.
@AnujRNair I have implemented the changes as requested. Let me know if there is anything else blocking this from being approved.
AnujRNair left a comment
AnujRNair left a comment There was a problem hiding this comment.
Thanks for the contribution!
3 participants
Summary
Implement Webpack 4 hooks API.
Requirements (place an
xin each[ ])